On 5/19/20 5:39 AM, Richard Henderson wrote:
On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote:
Fix OUTL instructions incorrectly displayed as OUTW.

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
  target/i386/misc_helper.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

as far as it goes.  We should of course never be printing to stderr, but
logging or tracing.

Yes, this is what the cpu_io() functions do in ioport.c, but they use MEMTXATTRS_UNSPECIFIED.

If we could replace one with another, I'm not sure which one is the correct one.

Maybe keep cpu_io() from ioport.c but add a MemTxAttrs argument?

Regards,

Phil.

Reply via email to