On 18/05/2020 07.03, Markus Armbruster wrote: > object_property_set_bool(OBJECT(dev), true, "realized", ...) right > after qdev_init_nofail(dev) does nothing, because qdev_init_nofail() > already realizes. Drop. > > Cc: BALATON Zoltan <bala...@eik.bme.hu> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/ppc/ppc440_uc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c > index b30e093cbb..dc318c7aa7 100644 > --- a/hw/ppc/ppc440_uc.c > +++ b/hw/ppc/ppc440_uc.c > @@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env) > dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST); > qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE); > qdev_init_nofail(dev); > - object_property_set_bool(OBJECT(dev), true, "realized", NULL); > ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env); > > dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST); > qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE); > qdev_init_nofail(dev); > - object_property_set_bool(OBJECT(dev), true, "realized", NULL); > ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env); > } >
Reviewed-by: Thomas Huth <th...@redhat.com>
