Patchew URL: https://patchew.org/QEMU/20200518122041.10694-1-mlevi...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200518122041.10694-1-mlevi...@redhat.com Subject: [PATCH v7 00/14] LUKS: encryption slot management using amend interface Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200512064900.28554-1-pauld...@gmail.com -> patchew/20200512064900.28554-1-pauld...@gmail.com - [tag update] patchew/20200518083704.52646-1-da...@redhat.com -> patchew/20200518083704.52646-1-da...@redhat.com * [new tag] patchew/20200518151255.10785-1-kra...@redhat.com -> patchew/20200518151255.10785-1-kra...@redhat.com * [new tag] patchew/20200518153025.13576-1-alex.ben...@linaro.org -> patchew/20200518153025.13576-1-alex.ben...@linaro.org Switched to a new branch 'test' 93adc63 iotests: add tests for blockdev-amend 4dd3bcb block/qcow2: implement blockdev-amend 3924c27 block/crypto: implement blockdev-amend 1fa4dd9 block/core: add generic infrastructure for x-blockdev-amend qmp command 386b94f iotests: qemu-img tests for luks key management e231475 iotests: filter few more luks specific create options 35ad578 block/qcow2: extend qemu-img amend interface with crypto options e7a1398 block/crypto: implement the encryption key management aabc8dc block/crypto: rename two functions b49aedc block/amend: refactor qcow2 amend options 7faebb5 block/amend: separate amend and create options for qemu-img 7fd48d8 block/amend: add 'force' option 03a65ce qcrypto/luks: implement encryption key management d5426f8 qcrypto/core: add generic infrastructure for crypto options amendment === OUTPUT BEGIN === 1/14 Checking commit d5426f85b5cf (qcrypto/core: add generic infrastructure for crypto options amendment) 2/14 Checking commit 03a65ce69afd (qcrypto/luks: implement encryption key management) 3/14 Checking commit 7fd48d81c1ff (block/amend: add 'force' option) 4/14 Checking commit 7faebb5b9d94 (block/amend: separate amend and create options for qemu-img) ERROR: Macros with multiple statements should be enclosed in a do - while loop #32: FILE: block/qcow2.c:5637: +#define QCOW_COMMON_OPTIONS \ + { \ + .name = BLOCK_OPT_SIZE, \ + .type = QEMU_OPT_SIZE, \ + .help = "Virtual disk size" \ + }, \ + { \ + .name = BLOCK_OPT_COMPAT_LEVEL, \ + .type = QEMU_OPT_STRING, \ + .help = "Compatibility level (v2 [0.10] or v3 [1.1])" \ + }, \ + { \ + .name = BLOCK_OPT_BACKING_FILE, \ + .type = QEMU_OPT_STRING, \ + .help = "File name of a base image" \ + }, \ + { \ + .name = BLOCK_OPT_BACKING_FMT, \ + .type = QEMU_OPT_STRING, \ + .help = "Image format of the base image" \ + }, \ + { \ + .name = BLOCK_OPT_DATA_FILE, \ + .type = QEMU_OPT_STRING, \ + .help = "File name of an external data file" \ + }, \ + { \ + .name = BLOCK_OPT_DATA_FILE_RAW, \ + .type = QEMU_OPT_BOOL, \ + .help = "The external data file must stay valid " \ + "as a raw image" \ + }, \ + { \ + .name = BLOCK_OPT_ENCRYPT, \ + .type = QEMU_OPT_BOOL, \ + .help = "Encrypt the image with format 'aes'. (Deprecated " \ + "in favor of " BLOCK_OPT_ENCRYPT_FORMAT "=aes)", \ + }, \ + { \ + .name = BLOCK_OPT_ENCRYPT_FORMAT, \ + .type = QEMU_OPT_STRING, \ + .help = "Encrypt the image, format choices: 'aes', 'luks'", \ + }, \ + BLOCK_CRYPTO_OPT_DEF_KEY_SECRET("encrypt.", \ + "ID of secret providing qcow AES key or LUKS passphrase"), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_CIPHER_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_CIPHER_MODE("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_IVGEN_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_IVGEN_HASH_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_HASH_ALG("encrypt."), \ + BLOCK_CRYPTO_OPT_DEF_LUKS_ITER_TIME("encrypt."), \ + { \ + .name = BLOCK_OPT_CLUSTER_SIZE, \ + .type = QEMU_OPT_SIZE, \ + .help = "qcow2 cluster size", \ + .def_value_str = stringify(DEFAULT_CLUSTER_SIZE) \ + }, \ + { \ + .name = BLOCK_OPT_PREALLOC, \ + .type = QEMU_OPT_STRING, \ + .help = "Preallocation mode (allowed values: off, " \ + "metadata, falloc, full)" \ + }, \ + { \ + .name = BLOCK_OPT_LAZY_REFCOUNTS, \ + .type = QEMU_OPT_BOOL, \ + .help = "Postpone refcount updates", \ + .def_value_str = "off" \ + }, \ + { \ + .name = BLOCK_OPT_REFCOUNT_BITS, \ + .type = QEMU_OPT_NUMBER, \ + .help = "Width of a reference count entry in bits", \ + .def_value_str = "16" \ + }, \ + { \ + .name = BLOCK_OPT_COMPRESSION_TYPE, \ + .type = QEMU_OPT_STRING, \ + .help = "Compression method used for image cluster " \ + "compression", \ + .def_value_str = "zlib" \ + } total: 1 errors, 0 warnings, 244 lines checked Patch 4/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/14 Checking commit b49aedccab95 (block/amend: refactor qcow2 amend options) 6/14 Checking commit aabc8dc7b6c0 (block/crypto: rename two functions) 7/14 Checking commit e7a1398191aa (block/crypto: implement the encryption key management) 8/14 Checking commit 35ad578c65eb (block/qcow2: extend qemu-img amend interface with crypto options) 9/14 Checking commit e231475b1b24 (iotests: filter few more luks specific create options) 10/14 Checking commit 386b94fced14 (iotests: qemu-img tests for luks key management) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100755 total: 0 errors, 1 warnings, 431 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit 1fa4dd9c14e7 (block/core: add generic infrastructure for x-blockdev-amend qmp command) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 221 lines checked Patch 11/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/14 Checking commit 3924c27718fc (block/crypto: implement blockdev-amend) 13/14 Checking commit 4dd3bcbb826b (block/qcow2: implement blockdev-amend) 14/14 Checking commit 93adc6369ead (iotests: add tests for blockdev-amend) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100755 total: 0 errors, 1 warnings, 591 lines checked Patch 14/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200518122041.10694-1-mlevi...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
