Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2005132345100.11...@digraph.polyomino.org.uk/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: alpine.deb.2.21.2005132345100.11...@digraph.polyomino.org.uk Subject: [PATCH 0/4] target/i386: miscellaneous x87 fixes Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200513011648.166876-1-ebl...@redhat.com -> patchew/20200513011648.166876-1-ebl...@redhat.com - [tag update] patchew/20200514035230.25756-1-js...@redhat.com -> patchew/20200514035230.25756-1-js...@redhat.com * [new tag] patchew/20200514055403.18902-1-js...@redhat.com -> patchew/20200514055403.18902-1-js...@redhat.com Switched to a new branch 'test' 9abdf27 target/i386: fix fbstp handling of out-of-range values 53fdfa9 target/i386: fix fbstp handling of negative zero 350fd81 target/i386: fix fxam handling of invalid encodings 0cd240c target/i386: fix floating-point load-constant rounding === OUTPUT BEGIN === 1/4 Checking commit 0cd240c60f14 (target/i386: fix floating-point load-constant rounding) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #107: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #117: FILE: tests/tcg/i386/test-i386-fldcst.c:6: +volatile long double ld_res; ERROR: spaces required around that '+' (ctx:VxV) #129: FILE: tests/tcg/i386/test-i386-fldcst.c:18: + if (ld_res != 0x3.5269e12f346e2bf8p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #138: FILE: tests/tcg/i386/test-i386-fldcst.c:27: + if (ld_res != 0x3.5269e12f346e2bf8p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #147: FILE: tests/tcg/i386/test-i386-fldcst.c:36: + if (ld_res != 0x3.5269e12f346e2bf8p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #156: FILE: tests/tcg/i386/test-i386-fldcst.c:45: + if (ld_res != 0x3.5269e12f346e2bfcp+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #166: FILE: tests/tcg/i386/test-i386-fldcst.c:55: + if (ld_res != 0x1.71547652b82fe178p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #175: FILE: tests/tcg/i386/test-i386-fldcst.c:64: + if (ld_res != 0x1.71547652b82fe176p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #184: FILE: tests/tcg/i386/test-i386-fldcst.c:73: + if (ld_res != 0x1.71547652b82fe176p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #193: FILE: tests/tcg/i386/test-i386-fldcst.c:82: + if (ld_res != 0x1.71547652b82fe178p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #203: FILE: tests/tcg/i386/test-i386-fldcst.c:92: + if (ld_res != 0x3.243f6a8885a308d4p+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #212: FILE: tests/tcg/i386/test-i386-fldcst.c:101: + if (ld_res != 0x3.243f6a8885a308dp+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #221: FILE: tests/tcg/i386/test-i386-fldcst.c:110: + if (ld_res != 0x3.243f6a8885a308dp+0L) { ^ ERROR: spaces required around that '+' (ctx:VxV) #230: FILE: tests/tcg/i386/test-i386-fldcst.c:119: + if (ld_res != 0x3.243f6a8885a308d4p+0L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #240: FILE: tests/tcg/i386/test-i386-fldcst.c:129: + if (ld_res != 0x4.d104d427de7fbcc8p-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #249: FILE: tests/tcg/i386/test-i386-fldcst.c:138: + if (ld_res != 0x4.d104d427de7fbccp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #258: FILE: tests/tcg/i386/test-i386-fldcst.c:147: + if (ld_res != 0x4.d104d427de7fbccp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #267: FILE: tests/tcg/i386/test-i386-fldcst.c:156: + if (ld_res != 0x4.d104d427de7fbcc8p-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #277: FILE: tests/tcg/i386/test-i386-fldcst.c:166: + if (ld_res != 0xb.17217f7d1cf79acp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #286: FILE: tests/tcg/i386/test-i386-fldcst.c:175: + if (ld_res != 0xb.17217f7d1cf79abp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #295: FILE: tests/tcg/i386/test-i386-fldcst.c:184: + if (ld_res != 0xb.17217f7d1cf79abp-4L) { ^ ERROR: spaces required around that '-' (ctx:VxV) #304: FILE: tests/tcg/i386/test-i386-fldcst.c:193: + if (ld_res != 0xb.17217f7d1cf79acp-4L) { ^ total: 21 errors, 1 warnings, 283 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit 350fd815b461 (target/i386: fix fxam handling of invalid encodings) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: Use of volatile is usually wrong, please add a comment #54: FILE: tests/tcg/i386/test-i386-fxam.c:11: +volatile union u ld_pseudo_m16382 = { .s = { UINT64_C(1) << 63, 0 } }; ERROR: Use of volatile is usually wrong, please add a comment #55: FILE: tests/tcg/i386/test-i386-fxam.c:12: +volatile union u ld_pseudo_nm16382 = { .s = { UINT64_C(1) << 63, 0x8000 } }; ERROR: Use of volatile is usually wrong, please add a comment #56: FILE: tests/tcg/i386/test-i386-fxam.c:13: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #57: FILE: tests/tcg/i386/test-i386-fxam.c:14: +volatile union u ld_invalid_2 = { .s = { 0, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #58: FILE: tests/tcg/i386/test-i386-fxam.c:15: +volatile union u ld_invalid_3 = { .s = { 0, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #59: FILE: tests/tcg/i386/test-i386-fxam.c:16: +volatile union u ld_invalid_4 = { .s = { (UINT64_C(1) << 63) - 1, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #60: FILE: tests/tcg/i386/test-i386-fxam.c:17: +volatile union u ld_invalid_n1 = { .s = { 1, 0x8123 } }; ERROR: Use of volatile is usually wrong, please add a comment #61: FILE: tests/tcg/i386/test-i386-fxam.c:18: +volatile union u ld_invalid_n2 = { .s = { 0, 0x8123 } }; ERROR: Use of volatile is usually wrong, please add a comment #62: FILE: tests/tcg/i386/test-i386-fxam.c:19: +volatile union u ld_invalid_n3 = { .s = { 0, 0xffff } }; ERROR: Use of volatile is usually wrong, please add a comment #63: FILE: tests/tcg/i386/test-i386-fxam.c:20: +volatile union u ld_invalid_n4 = { .s = { (UINT64_C(1) << 63) - 1, 0xffff } }; ERROR: spaces required around that '-' (ctx:VxV) #125: FILE: tests/tcg/i386/test-i386-fxam.c:82: + __asm__ volatile ("fxam\nfnstsw" : "=a" (sw) : "t" (0x1p-16445L)); ^ ERROR: spaces required around that '-' (ctx:VxV) #130: FILE: tests/tcg/i386/test-i386-fxam.c:87: + __asm__ volatile ("fxam\nfnstsw" : "=a" (sw) : "t" (-0x1p-16445L)); ^ total: 12 errors, 1 warnings, 159 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit 53fdfa9ee04d (target/i386: fix fbstp handling of negative zero) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 40 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 9abdf27f3157 (target/i386: fix fbstp handling of out-of-range values) ERROR: Use of volatile is usually wrong, please add a comment #55: FILE: tests/tcg/i386/test-i386-fbstp.c:12: +volatile union u ld_invalid_1 = { .s = { 1, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #56: FILE: tests/tcg/i386/test-i386-fbstp.c:13: +volatile union u ld_invalid_2 = { .s = { 0, 1234 } }; ERROR: Use of volatile is usually wrong, please add a comment #57: FILE: tests/tcg/i386/test-i386-fbstp.c:14: +volatile union u ld_invalid_3 = { .s = { 0, 0x7fff } }; ERROR: Use of volatile is usually wrong, please add a comment #58: FILE: tests/tcg/i386/test-i386-fbstp.c:15: +volatile union u ld_invalid_4 = { .s = { (UINT64_C(1) << 63) - 1, 0x7fff } }; total: 4 errors, 0 warnings, 144 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/alpine.deb.2.21.2005132345100.11...@digraph.polyomino.org.uk/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
