On 5/4/20 1:46 AM, Philippe Mathieu-Daudé wrote: > We need "qom/object.h" to call object_ref()/object_unref().
This description doesn't seem to match > +++ b/include/io/task.h > @@ -21,8 +21,6 @@ > #ifndef QIO_TASK_H > #define QIO_TASK_H > > -#include "qom/object.h" > - > typedef struct QIOTask QIOTask; > > typedef void (*QIOTaskFunc)(QIOTask *task, > diff --git a/io/task.c b/io/task.c > index 1ae7b86488..53c0bed686 100644 > --- a/io/task.c > +++ b/io/task.c > @@ -22,6 +22,7 @@ > #include "io/task.h" > #include "qapi/error.h" > #include "qemu/thread.h" > +#include "qom/object.h" the change. Since io/task.c includes io/tash.h, what are you actually doing? r~
