On 4/30/20 8:09 PM, Peter Maydell wrote:
Somewhere along theline we accidentally added a duplicate

"the line"?

"using D16-D31 when they don't exist" check to do_vfm_dp()
(probably an artifact of a patchseries rebase). Remove it.

Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
---
  target/arm/translate-vfp.inc.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c
index b087bbd812e..e1a90175983 100644
--- a/target/arm/translate-vfp.inc.c
+++ b/target/arm/translate-vfp.inc.c
@@ -1872,12 +1872,6 @@ static bool do_vfm_dp(DisasContext *s, arg_VFMA_dp *a, 
bool neg_n, bool neg_d)
          return false;
      }
- /* UNDEF accesses to D16-D31 if they don't exist. */
-    if (!dc_isar_feature(aa32_simd_r32, s) &&
-        ((a->vd | a->vn | a->vm) & 0x10)) {
-        return false;
-    }
-
      if (!vfp_access_check(s)) {
          return true;
      }


Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Reply via email to