On Fri, 1 May 2020 at 09:28, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > The following changes since commit 27c94566379069fb8930bb1433dcffbf7df3203d: > > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/xilinx-next-2020-04-30.for-upstream' into staging > (2020-04-30 16:47:23 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to cc1adc4488059ac16d4d2772a7aa7cd1323deeca: > > lockable: Replace locks with lock guard macros (2020-05-01 09:19:25 +0100) > > ---------------------------------------------------------------- > Pull request > > Fix the QEMU_LOCK_GUARD() macros, use them more widely, and allow the fuzzer > target to be selected from argv[0]. > > ----------------------------------------------------------------
Hi; this pullreq seems to include a stray change to the slirp submodule in the "fuzz: select fuzz target using executable name" commit. Could you fix that and resend, please? (You might like to include a molly-guard in your pullreq creation scripts; on my end I catch this sort of thing when applying with a test like if git diff master..staging | grep -q 'Subproject commit'; then # complain and exit unless I used an explicit command # line option to say I intended to include a submodule update fi though I haven't yet put the same test in the script I use to send pullreqs, for some reason. I guess my workflow now means I don't tend to accidentally commit submodule changes.) thanks -- PMM