> -----Original Message----- > From: Paul Durrant <xadimg...@gmail.com> > Sent: 28 April 2020 13:33 > To: 'Artur Puzio' <ar...@puzio.waw.pl>; 'Grzegorz Uriasz' > <gorba...@gmail.com>; qemu-devel@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' <sstabell...@kernel.org>; 'Anthony Perard' > <anthony.per...@citrix.com>; xen- > de...@lists.xenproject.org > Subject: RE: [PATCH 1/2] Fix undefined behaviour > > > -----Original Message----- > > From: Artur Puzio <ar...@puzio.waw.pl> > > Sent: 28 April 2020 10:41 > > To: p...@xen.org; 'Grzegorz Uriasz' <gorba...@gmail.com>; > > qemu-devel@nongnu.org > > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > > j.nowa...@student.uw.edu.pl; 'Stefano > > Stabellini' <sstabell...@kernel.org>; 'Anthony Perard' > > <anthony.per...@citrix.com>; xen- > > de...@lists.xenproject.org > > Subject: Re: [PATCH 1/2] Fix undefined behaviour > > > > On 28.04.2020 10:10, Paul Durrant wrote: > > >> -----Original Message----- > > >> From: Grzegorz Uriasz <gorba...@gmail.com> > > >> Sent: 28 April 2020 07:29 > > >> To: qemu-devel@nongnu.org > > >> Cc: Grzegorz Uriasz <gorba...@gmail.com>; > > >> marma...@invisiblethingslab.com; ar...@puzio.waw.pl; > > >> ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano Stabellini > > >> <sstabell...@kernel.org>; > > Anthony > > >> Perard <anthony.per...@citrix.com>; Paul Durrant <p...@xen.org>; > > >> xen-de...@lists.xenproject.org > > >> Subject: [PATCH 1/2] Fix undefined behaviour > > >> > > >> Signed-off-by: Grzegorz Uriasz <gorba...@gmail.com> > > > I think we need more of a commit comment for both this and patch #2 to > > > explain why you are making > > the changes. > > > > > > Paul > > > > I agree Grzegorz should improve the commit messages. In the mean time > > see email with subject "[PATCH 0/2] Fix QEMU crashes when passing IGD to > > a guest VM under XEN", it contains quite detailed explanation for both > > "Fix undefined behaviour" and "Improve legacy vbios handling" patches. > > > > Ok. Can you please make sure maintainers are cc-ed on patch #0 too. >
Actually they are, sorry. My MUA is playing tricks on me. Paul
