On 27/04/20 14:33, Markus Armbruster wrote: > [1] a device on dev->child_bus fails to > unrealize, or [3] @dev itself fails to unrealize. We hold on to the > first failure, and continue to unrealize. device_set_realized() fails > when any of these fail. > > Issue #1: What if some, but not all fail? How can this possibly work? > > Issue #2: Even if all fail, and therefore both the device and the ones > on ->child_bus all remain realized, there are side effects at [2] and > [4]. > > Any better ideas than &error_abort?
I don't think we have unrealizes that fail, so removing the argument and &error_abort is the best idea. Paolo