On 4/27/20 3:04 PM, Peter Maydell wrote:
On Thu, 23 Apr 2020 at 08:34, Philippe Mathieu-Daudé <[email protected]> wrote:
These are the uncontroversial patches from "Support disabling
TCG on ARM (part 2)"
https://www.mail-archive.com/[email protected]/msg689168.html
The other patches are blocked by the "accel: Allow targets to
use Kconfig" series:
https://www.mail-archive.com/[email protected]/msg689024.html
All patches reviewed.
Since v1:
- Dropped 'Make set_feature() available for other files' patch
which fails to build with KVM only, see:
https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03843.html
Many thanks to Richard Henderson for his patience!
Regards,
Phil.
Philippe Mathieu-Daudé (4):
target/arm: Restric the Address Translate write operation to TCG accel
target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]
target/arm/cpu: Update coding style to make checkpatch.pl happy
target/arm: Restrict TCG cpus to TCG accel
Thomas Huth (1):
target/arm: Make cpu_register() available for other files
Patch 5 doesn't compile, because it moves code out from
cpu.c to cpu_tcg.c, where it no longer has access to the
file-local set_feature() function:
CC arm-softmmu/target/arm/cpu_tcg.o
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu_tcg.c:47:5:
error: implicit declaration of function 'set_feature' is invalid in
C99
[-Werror,-Wimplicit-function-declaration]
set_feature(&cpu->env, ARM_FEATURE_V5);
^
[etc]
*Sigh* sorry for that, I'm still unsure what's the cleaner change to
deal with the different set_feature() KVM prototype:
https://www.mail-archive.com/[email protected]/msg697523.html
I've applied patches 1-4 to target-arm.next.
Thanks for this!
thanks
-- PMM
