Patchew URL: https://patchew.org/QEMU/20200427121823.8094-1-changbin...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference Message-id: 20200427121823.8094-1-changbin...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' cc4f090 ui/sdl2: fix segment fault caused by null pointer dereference === OUTPUT BEGIN === ERROR: braces {} are necessary for all arms of this statement #32: FILE: ui/sdl2.c:418: + if (!sconf) [...] ERROR: braces {} are necessary for all arms of this statement #42: FILE: ui/sdl2.c:430: + if (!con) [...] total: 2 errors, 0 warnings, 27 lines checked Commit cc4f090c07bc (ui/sdl2: fix segment fault caused by null pointer dereference) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200427121823.8094-1-changbin...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com