Patchew URL: https://patchew.org/QEMU/20200420083236.19309-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/11] Miscellaneous error handling fixes Message-id: 20200420083236.19309-1-arm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 942181b migration/colo: Fix qmp_xen_colo_do_checkpoint() error handling a8c2f29 io: Fix qio_channel_socket_close() error handling cedb56e xen/pt: Fix flawed conversion to realize() 7173a0e virtio-net: Fix duplex=... and speed=... error handling 9c7afc3 bochs-display: Fix vgamem=SIZE error handling f3ad7d4 fdc: Fix fallback=auto error handling e484e15 arm/virt: Fix virt_machine_device_plug_cb() error API violation 1c54f10 cpus: Proper range-checking for -icount shift=N 0a69dc4 cpus: Fix configure_icount() error API violation bafe5f5 block/file-posix: Fix check_cache_dropped() error handling a690fa1 cryptodev: Fix cryptodev_builtin_cleanup() error API violation === OUTPUT BEGIN === 1/11 Checking commit a690fa1dc425 (cryptodev: Fix cryptodev_builtin_cleanup() error API violation) 2/11 Checking commit bafe5f5e9888 (block/file-posix: Fix check_cache_dropped() error handling) 3/11 Checking commit 0a69dc45007c (cpus: Fix configure_icount() error API violation) ERROR: consider using qemu_strtol in preference to strtol #58: FILE: cpus.c:818: + time_shift = strtol(option, &rem_str, 0); total: 1 errors, 0 warnings, 70 lines checked Patch 3/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/11 Checking commit 1c54f102aed3 (cpus: Proper range-checking for -icount shift=N) 5/11 Checking commit e484e1536ed7 (arm/virt: Fix virt_machine_device_plug_cb() error API violation) 6/11 Checking commit f3ad7d444a66 (fdc: Fix fallback=auto error handling) 7/11 Checking commit 9c7afc3c57a4 (bochs-display: Fix vgamem=SIZE error handling) 8/11 Checking commit 7173a0e399fd (virtio-net: Fix duplex=... and speed=... error handling) 9/11 Checking commit cedb56ec3da3 (xen/pt: Fix flawed conversion to realize()) 10/11 Checking commit a8c2f294abb2 (io: Fix qio_channel_socket_close() error handling) 11/11 Checking commit 942181b72505 (migration/colo: Fix qmp_xen_colo_do_checkpoint() error handling) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200420083236.19309-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
