Re: [PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

[Philippe Mathieu-Daudé]

On 4/17/20 9:44 AM, Yan Zhao wrote:

for ram device regions, drop guest writes if the regions is read-only.

Cc: Philippe Mathieu-Daudé <phi...@redhat.com>
Signed-off-by: Yan Zhao <yan.y.z...@intel.com>
Signed-off-by: Xin Zeng <xin.z...@intel.com>
---
  memory.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/memory.c b/memory.c
index 601b749906..9576dd6807 100644
--- a/memory.c
+++ b/memory.c
@@ -34,6 +34,7 @@
  #include "sysemu/accel.h"
  #include "hw/boards.h"
  #include "migration/vmstate.h"
+#include "qemu/log.h"

//#define DEBUG_UNASSIGNED @@ -1313,6 +1314,12 @@ static void memory_region_ram_device_write(void *opaque, hwaddr addr,

      MemoryRegion *mr = opaque;

trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, size);

+    if (mr->readonly) {
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "Invalid write to read only ram device region 0x%"
+                       HWADDR_PRIx" size %u\n", addr, size);
+        return;
+    }

switch (size) {

      case 1:

Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>