Patchew URL: https://patchew.org/QEMU/20200416203624.32366-1-mlevi...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread Message-id: 20200416203624.32366-1-mlevi...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200416212349.731404-1-ebl...@redhat.com -> patchew/20200416212349.731404-1-ebl...@redhat.com Switched to a new branch 'test' 5e47155 virtio-scsi: don't touch scsi devices that are not yet realized 7a4e20b device-core: use atomic_set on .realized property c8c6d72 device-core: use RCU for list of childs of a bus 7b3ca63 scsi/scsi_bus: switch search direction in scsi_device_find === OUTPUT BEGIN === 1/4 Checking commit 7b3ca636be2f (scsi/scsi_bus: switch search direction in scsi_device_find) 2/4 Checking commit c8c6d7230602 (device-core: use RCU for list of childs of a bus) ERROR: space required before the open brace '{' #34: FILE: hw/core/bus.c:52: + WITH_RCU_READ_LOCK_GUARD(){ ERROR: space required before the open brace '{' #88: FILE: hw/core/bus.c:200: + WITH_RCU_READ_LOCK_GUARD(){ total: 2 errors, 0 warnings, 255 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit 7a4e20bf9d25 (device-core: use atomic_set on .realized property) 4/4 Checking commit 5e47155794bf (virtio-scsi: don't touch scsi devices that are not yet realized) WARNING: Block comments use a leading /* on a separate line #33: FILE: hw/scsi/virtio-scsi.c:49: + /* This function might run on the IO thread and we might race against total: 0 errors, 1 warnings, 30 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200416203624.32366-1-mlevi...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
