On 4/13/20 12:59 PM, Michael S. Tsirkin wrote:
On Mon, Mar 23, 2020 at 09:41:20AM -0400, Michael S. Tsirkin wrote:
On Mon, Mar 23, 2020 at 12:29:40PM +0100, Philippe Mathieu-Daudé wrote:
Coverity reported a ALLOC_FREE_MISMATCH in vg_handle_cursor(),
because the memory returned by vu_queue_pop() is allocated with
malloc(). Fix it.
Similar error occurs with virtio. Document and fix.
I will queue this. Thanks!
So what are we doing with this patchset? Marc-André reported issues -
any plan to fix them up? Split up the patchset to 3 independent
patches?
As noted Marc-André, patches 2 & 3 are incorrect.
Patch 1 can be queued as it with no modification.
Philippe Mathieu-Daudé (3):
vhost-user-gpu: Release memory returned by vu_queue_pop() with free()
virtio: Document virtqueue_pop()
virtio-gpu: Release memory returned by virtqueue_pop() with free()
include/hw/virtio/virtio.h | 8 ++++++++
contrib/vhost-user-gpu/vhost-user-gpu.c | 4 ++--
contrib/vhost-user-gpu/virgl.c | 2 +-
hw/display/virtio-gpu-3d.c | 2 +-
hw/display/virtio-gpu.c | 8 ++++----
5 files changed, 16 insertions(+), 8 deletions(-)
--
2.21.1
