On Tue 14 Apr 2020 02:30:30 PM CEST, Vladimir Sementsov-Ogievskiy wrote: >> - ret = qcow2_get_host_offset(bs, offset, &nr, &off); >> - if (ret != QCOW2_CLUSTER_UNALLOCATED && >> - ret != QCOW2_CLUSTER_ZERO_PLAIN && >> - ret != QCOW2_CLUSTER_ZERO_ALLOC) { >> + ret = qcow2_get_host_offset(bs, offset, &nr, &off, &type); > > pre-patch, but probably better to return original errno on > qcow2_get_host_offset failure, instead of masking it.
Yeah, I think you're right. I can take care of that on a separate patch. Berto