> -----Original Message-----
> From: Qemu-devel <qemu-devel-
> bounces+bcain=codeaurora....@nongnu.org> On Behalf Of Taylor Simpson
> Sent: Friday, February 28, 2020 10:43 AM
> To: qemu-devel@nongnu.org
> Cc: riku.voi...@iki.fi; richard.hender...@linaro.org; laur...@vivier.eu;
> Taylor Simpson <tsimp...@quicinc.com>; phi...@redhat.com;
> aleksandar.m.m...@gmail.com
> Subject: [RFC PATCH v2 20/67] Hexagon instruction utility functions
...
> +int arch_sf_invsqrt_common(size4s_t *Rs, size4s_t *Rd, int *adjust)
> +{
...
> + } else if (r_class == FP_INFINITE) {
> + /* EJP: or put Inf in num fixup? */
> + RsV = fSFINFVAL(-1);
> + RdV = fSFINFVAL(-1);
> + } else if (r_class == FP_ZERO) {
> + /* EJP: or put zero in num fixup? */
> + RsV = RsV;
> + RdV = fSFONEVAL(0);
...
This "RsV = RsV" looks like a logic error? Presumably it's safe to remove --
unless there's some other field that should get initialized here? PeV maybe?
