On 08.04.20 19:46, Alberto Garcia wrote:
> On Wed 08 Apr 2020 01:23:42 PM CEST, Max Reitz wrote:
>>> + switch (type) {
>>> + case QCOW2_CLUSTER_COMPRESSED:
>>> + return QCOW2_SUBCLUSTER_COMPRESSED;
>>
>> Why did you drop the check that l2_bitmap == 0 here?
>
> We don't generally check that reserved bits are 0. It would for example
> allow us to add a new compatible feature in the future using those bits.OK. The spec as you wrote it would allow that, and if we ever used those bits we’d probably need to add a feature bit to the header anyway. (More so if we returned an error here.) Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
