Markus Armbruster <arm...@redhat.com> writes:
> Simran Singhal <singhalsimr...@gmail.com> writes:
>
>> Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0"
>> to fix the typo.
>>
>> Fixes: 8d3265b3
>>
>> Reviewed-by: Eric Blake <ebl...@redhat.com>
>> Signed-off-by: Simran Singhal <singhalsimr...@gmail.com>
>
> First, thank you so much for spotting and fixing my typo!
>
> The commit message neglects to explain what is broken. I'd like to use
> this one:
>
> json: Fix check for unbalanced right curly brace
>
> We immediately diagnose unbalanced right curly brace:
>
> $ qemu-kvm --nodefaults --nographic --qmp stdio
> {"QMP": {"version": {"qemu": {"micro": 91, "minor": 2, "major": 4},
> "package": "v5.0.0-rc1-1-gf6ce4a439a08"}, "capabilities": ["oob"]}}
> }
> {"error": {"class": "GenericError", "desc": "JSON parse error,
> expecting value"}}
>
> except within square bracket:
>
> [}
>
> The check for unbalanced braces has a typo. Fix it.
>
> Fixes: 8d3265b3d00db1071d1d3bf8433b4818088fdeb5
> Signed-off-by: Simran Singhal <singhalsimr...@gmail.com>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
> Objections?
Apparently none. Queued, thanks!
[...]
