>-----Original Message----- >From: Laurent Vivier [mailto:laur...@vivier.eu] >Sent: Friday, April 3, 2020 4:04 PM >To: Chenqun (kuhn) <kuhn.chen...@huawei.com>; qemu-devel@nongnu.org; >qemu-triv...@nongnu.org >Cc: Zhanghailiang <zhang.zhanghaili...@huawei.com>; phi...@redhat.com >Subject: Re: [PATCH v5 0/3] redundant code: Fix warnings reported by Clang >static code analyzer > >Le 03/04/2020 à 09:51, Chenqun (kuhn) a écrit : >> Ping! >> >> This series has been reviewed. Could someone please pick this up (e.g. qemu- >trivial?)? > >As we are in hard feature freeze now and this is not critical bug fixes I'm >going >to queue them for 5.1 except if you have good arguments to have them in 5.0. > OK, I get it. It is important to ensure a stable version!
Thanks. >>> -----Original Message----- >>> From: Chenqun (kuhn) >>> Sent: Wednesday, March 25, 2020 10:59 AM >>> To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org >>> Cc: Zhanghailiang <zhang.zhanghaili...@huawei.com>; >>> laur...@vivier.eu; phi...@redhat.com; Chenqun (kuhn) >>> <kuhn.chen...@huawei.com> >>> Subject: [PATCH v5 0/3] redundant code: Fix warnings reported by >>> Clang static code analyzer >>> >>> v1->v2: >>> - Patch1: Add John Snow review comment. >>> - Patch9: Move the 'dst_type' declaration to while() statement. >>> - Patch12: Add Philippe Mathieu-Daud茅 review comment. >>> - Patch13: Move the 'set' declaration to the for() statement. >>> >>> v2->v3: >>> - Patch1: Add Kevin Wolf review comment. >>> - Patch2: Keep the 'flags' then use it(Base on Kevin's comments). >>> - Patch3: Add Kevin Wolf review comment. >>> - Patch9: Add Francisco Iglesias and Alistair Francis review comment. >>> - Patch10: Juan Quintela has added it to the queue and delete it. >>> - Patch12->Patch11: Add Philippe Mathieu-Daud茅 review comment. >>> - Patch13->Patch12: Add Philippe Mathieu-Daud茅 review comment. >>> >>> v3->v4: >>> - Deleted the patches that have been merged in the v3. >>> - Modify "scsi/esp-pci" Patch, use g_assert with variable size. >>> >>> v4->v5: >>> - Patch1: Add Laurent Vivier review comment and change the subject. >>> - Patch2: Use extract16() instead of delete bit operation statement. >>> - Patch3: Add Laurent Vivier review comment. >>> >>> Chen Qun (3): >>> scsi/esp-pci: add g_assert() for fix clang analyzer warning in >>> esp_pci_io_write() >>> display/blizzard: use extract16() for fix clang analyzer warning in >>> blizzard_draw_line16_32() >>> timer/exynos4210_mct: Remove redundant statement in >>> exynos4210_mct_write() >>> >>> hw/display/blizzard.c | 10 ++++------ >>> hw/scsi/esp-pci.c | 1 + >>> hw/timer/exynos4210_mct.c | 4 ---- >>> 3 files changed, 5 insertions(+), 10 deletions(-) >>> >>> -- >>> 2.23.0 >>> >>
