Re: Questionable aspects of QEMU Error's design

[Eric Blake]

On 4/2/20 12:54 AM, Markus Armbruster wrote:

Peter Maydell <peter.mayd...@linaro.org> writes:

It's a small improvement.  A bigger one is

         if (object_property_set_link(cpuobj, OBJECT(&s->cpu_container[i]),
                                      "memory", errp)) {
             return;
         }
         if (object_property_set_link(cpuobj, OBJECT(s), "idau", errp)) {
             return;
         }
         if (object_property_set_bool(cpuobj, true, "realized", errp)) {
             return;
         }

Or even:

if (object_property_set_link(cpuobj, OBJECT(&s->cpu_container[i]),
                                      "memory", errp) ||
    object_property_set_link(cpuobj, OBJECT(s), "idau", errp) ||
    object_property_set_bool(cpuobj, true, "realized", errp)) {
        return;
}

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org