On Wed, 1 Apr 2020 14:04:17 +0200 David Hildenbrand <da...@redhat.com> wrote:
> > something like > > > > while ((sz >> increment_size) > MAX_STORAGE_INCREMENTS) { > > increment_size++; > > } > > newsz = sz >> increment_size << increment_size; > > > > if (sz != newsz) { > > qemu_printf("Ram size %" PRIu64 "MB was fixed up to %" PRIu64 > > Maybe warn_report() The _report() functions prescribe using just a single sentence without trailing period, though. The only real difference is whether the message goes to stderr or stdout in absence of a monitor. > > > "MB to match machine restrictions. Consider updating " > > "the guest definition.\n", > > sz / MiB, newsz / MiB); > > might be able to squeeze that into the previous line. > > > } > > return newsz; > > > > ? > > Much better. Seconded :)