Am 31.03.2020 um 16:56 hat Daniel P. Berrangé geschrieben: > On Tue, Mar 31, 2020 at 09:44:37AM -0500, Eric Blake wrote: > > On 3/31/20 5:37 AM, Daniel P. Berrangé wrote: > > > Running configure directly from the source directory is a build > > > configuration that will go away in future. It is also not currently > > > covered by any automated testing. Display a deprecation warning if > > > the user attempts to use an in-srcdir build setup, so that they are > > > aware that they're building QEMU in an undesirable manner. > > > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
> > > @@ -6799,6 +6812,23 @@ if test "$supported_os" = "no"; then > > > echo "us upstream at qemu-devel@nongnu.org." > > > fi > > > +if test "$in_srcdir" = "yes"; then > > > + echo > > > + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" > > > + echo > > > + echo "Support for running the 'configure' script directly from the" > > > + echo "source directory is deprecated and will go away in a future" > > > + echo "release. In source dir builds are not covered by automated" > > > + echo "testing and are liable to break without warning. Users are" > > > + echo "strongly recommended to switch to a separate build directory:" > > > + echo > > > + echo " $ mkdir build" > > > + echo " $ cd build" > > > + echo " $ ../configure" > > > + echo " $ make" > > > + echo > > > +fi > > > > You know, it WOULD be possible to further enhance this to actually create > > 'build' as well as a shim GNUmakefile that would auto-forward on to building > > directly in build, so that you maintain the illusion of an in-place build > > (other than all the build artifacts now living in a different location), and > > muscle memory for in-tree 'make' still works; I've posted elsewhere and will > > repeat here the contents of my GNUmakefile: > > I wanted to focus strictly on the part that we have agreement on, namely > the deprecation. Any functional changes should be completely separate > to avoid holding up the merge of the warning message patch. We don't have agreement on the type of deprecation suggested by your message, that is, that ./configure from the source directory will stop working. If we can agree on using Eric's approach, then the message should rather tell users that the resulting binaries will move to a different place in future versions. Kevin
