Philippe Mathieu-Daudé <f4...@amsat.org> writes: > This series is inspired of Peter fix: > "hw/arm/xlnx-zynqmp.c: fix some error-handling code" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691636.html > > Add a cocci script to fix the other places. > > Based-on: <20200324134947.15384-1-peter.mayd...@linaro.org>
I skimmed the code patches [PATCH 02-12/12], and they look like bug fixes. Other reviewers raised a few issues. I also skimmed the Coccinelle script [PATCH 01]. Peter pointed out a few things it apparently missed (e.g. in review of PATCH 06+11). Moreover, the bug pattern applies beyond object_property_set() & friends. Perhaps the script can be generalized. No reason to hold fixes. We may want to add suitable notes to the scipt, though. Can you address the reviews in a v2, so we can get the fixes into -rc1, due today?
