On Thu, Mar 19, 2020 at 04:35:59PM +0000, Stefan Hajnoczi wrote: > When external event sources are disabled fdmon-io_uring falls back to > fdmon-poll. The ->need_wait() callback needs to watch for this so it > can return true when external event sources are disabled. > > It is also necessary to call ->wait() when AioHandlers have changed > because io_uring is asynchronous and we must submit new sqes. > > Both of these changes to ->need_wait() together fix tests/test-aio -p > /aio/external-client, which failed with: > > test-aio: tests/test-aio.c:404: test_aio_external_client: Assertion > `aio_poll(ctx, false)' failed. > > Reported-by: Julia Suvorova <jus...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > util/fdmon-io_uring.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
signature.asc
Description: PGP signature
