On 3/21/20 3:41 PM, Philippe Mathieu-Daudé wrote:
> Fix warning reported by Clang static code analyzer:
>
> hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its
> initialization is never read
> int set_idx, g_idx = *group_idx;
> ^~~~~ ~~~~~~~~~~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Cédric Le Goater <c...@kaod.org>
> ---
> v2: Do not declare g_idx in for() (Zoltan)
> ---
> hw/gpio/aspeed_gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
> index 41e11ea9b0..bd19db31f4 100644
> --- a/hw/gpio/aspeed_gpio.c
> +++ b/hw/gpio/aspeed_gpio.c
> @@ -714,7 +714,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr
> offset, uint64_t data,
> static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_idx)
> {
> AspeedGPIOClass *agc = ASPEED_GPIO_GET_CLASS(s);
> - int set_idx, g_idx = *group_idx;
> + int set_idx, g_idx;
>
> for (set_idx = 0; set_idx < agc->nr_gpio_sets; set_idx++) {
> const GPIOSetProperties *set_props = &agc->props[set_idx];
>
