From: BALATON Zoltan <bala...@eik.bme.hu> Spaces are required around a + operator and if statements should have braces even for single line. Also make it simpler by reversing the condition instead of breaking the loop.
Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Message-id: 0d50336ab26a56240c8c17ca1ec6135a4092fcc9.1584457537.git.bala...@eik.bme.hu Signed-off-by: John Snow <js...@redhat.com> --- hw/ide/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 4fc76c5225..e0c84392e2 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -485,9 +485,9 @@ void pci_ide_create_devs(PCIDevice *dev, DriveInfo **hd_table) int i; for (i = 0; i < 4; i++) { - if (hd_table[i] == NULL) - continue; - ide_create_drive(d->bus+bus[i], unit[i], hd_table[i]); + if (hd_table[i]) { + ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); + } } } -- 2.21.1