On 3/17/20 6:54 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---

+++ b/qapi/introspect.json
@@ -206,11 +206,15 @@
  #           Future extension: if present and non-null, the parameter
  #           is optional, and defaults to this value.
  #
+# @features: names of features associated with the member, in no
+#            particular order.  (since 5.0)

We're down to the soft-freeze wire ;)

+#
  # Since: 2.5
  ##
  { 'struct': 'SchemaInfoObjectMember',
-  'data': { 'name': 'str', 'type': 'str', '*default': 'any' } }
+  'data': { 'name': 'str', 'type': 'str', '*default': 'any',
  # @default's type must be null or match @type
+            '*features': [ 'str' ] } }

The comment was outside the overall definition, and now occurs mid-object. I might have listed '*features' first, leaving '*default' last so that the comment can still be outside the overall struct. But that's aesthetics; the QAPI parser handles things correctly as-is.

Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Reply via email to