On Tue, 17 Mar 2020 08:51:50 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/158444819283.31599.12155058652686614304.stgit@jupiter/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH] ppc/spapr: Set the effective address provided flag in mc > error log. > Message-id: 158444819283.31599.12155058652686614304.stgit@jupiter > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Switched to a new branch 'test' > 62d8ada ppc/spapr: Set the effective address provided flag in mc error log. > > === OUTPUT BEGIN === > ERROR: code indent should never use tabs > #57: FILE: hw/ppc/spapr_events.c:739: > +^Iswitch (ext_elog->mc.error_type) {$ >
Yeah no tabs allowed in the QEMU code (see CODING_STYLE.rst). If your editor is emacs, you can consider setting these: (setq indent-tabs-mode nil) (setq c-basic-offset 4)) > ERROR: code indent should never use tabs > #58: FILE: hw/ppc/spapr_events.c:740: > +^Icase RTAS_LOG_V6_MC_TYPE_UE:$ > > ERROR: code indent should never use tabs > #59: FILE: hw/ppc/spapr_events.c:741: > +^I^Iext_elog->mc.sub_err_type |= RTAS_LOG_V6_MC_UE_EA_ADDR_PROVIDED;$ > > ERROR: code indent should never use tabs > #60: FILE: hw/ppc/spapr_events.c:742: > +^I^Ibreak;$ > > ERROR: code indent should never use tabs > #61: FILE: hw/ppc/spapr_events.c:743: > +^Icase RTAS_LOG_V6_MC_TYPE_SLB:$ > > ERROR: code indent should never use tabs > #62: FILE: hw/ppc/spapr_events.c:744: > +^Icase RTAS_LOG_V6_MC_TYPE_ERAT:$ > > ERROR: code indent should never use tabs > #63: FILE: hw/ppc/spapr_events.c:745: > +^Icase RTAS_LOG_V6_MC_TYPE_TLB:$ > > ERROR: code indent should never use tabs > #64: FILE: hw/ppc/spapr_events.c:746: > +^I^Iext_elog->mc.sub_err_type |= RTAS_LOG_V6_MC_EA_ADDR_PROVIDED;$ > > ERROR: code indent should never use tabs > #65: FILE: hw/ppc/spapr_events.c:747: > +^I^Ibreak;$ > > ERROR: code indent should never use tabs > #66: FILE: hw/ppc/spapr_events.c:748: > +^Idefault:$ > > ERROR: code indent should never use tabs > #67: FILE: hw/ppc/spapr_events.c:749: > +^I^Ibreak;$ > > ERROR: code indent should never use tabs > #68: FILE: hw/ppc/spapr_events.c:750: > +^I}$ > > total: 12 errors, 0 warnings, 50 lines checked > > Commit 62d8adac0688 (ppc/spapr: Set the effective address provided flag in mc > error log.) has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/158444819283.31599.12155058652686614304.stgit@jupiter/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com
