Eric Blake <ebl...@redhat.com> writes: > On 3/15/20 9:46 AM, Markus Armbruster wrote: >> A number of deprecated QMP arguments and results were missed in commit >> eb22aeca65 "docs: document deprecation policy & deprecated features in >> appendix" (v2.10.0): >> > >> >> Since then, we missed a few more: >> >> * Commit 3c605f4074 "commit: Add top-node/base-node options" (v3.1.0) >> deprecated block-commit arguments @base and @top. >> >> * Commit 4db6ceb0b5 "block/dirty-bitmap: add recording and busy >> properties" (v4.0.0) deprecated query-named-block-nodes result >> @dirty-bitmaps member @status, not just query-block. >> >> Make up for all that. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> docs/system/deprecated.rst | 48 ++++++++++++++++++++++++++++++++++---- >> 1 file changed, 44 insertions(+), 4 deletions(-) > > Should we remove any of these features that have been deprecated long > enough? But that can be separate, having this patch just add mention > that was previously forgotten is fine.
Up to the subsystem maintainers, I'd say. I think we should sweep deprecated.rst on every release. Early in the development cycle seems best. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!