On Fri, Mar 13, 2020 at 12:30:51PM +0100, Greg Kurz wrote: > On Fri, 13 Mar 2020 15:05:36 +1100 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > Currently this node with information about hotpluggable memory is created > > from spapr_dt_cas_updates(). But that's just a hangover from when we > > created it only as a diff to the device tree at CAS time. Now that we > > fully rebuild the DT as CAS time, it makes more sense to create this along > > with the rest of the memory information in the device tree. > > > > So, move it to spapr_populate_memory(). The patch is huge, but it's nearly > > all just code motion. > > > > The change looks good but it may be possible to improve the diffstat, > see some comments below.
[snip]
> > -
> > -static int spapr_rng_populate_dt(void *fdt)
>
> I'm not quite sure why this function needs to move...
Eh, I guess it didn't. I'm disinclined to change it now though, so I
can get this in for tomorrows last-PR-before-soft-freeze.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
