On 13/03/2020 21:14, BALATON Zoltan wrote: > These are some clean ups to remove more legacy init functions and > lessen dependence on include/hw/ide.h with some simplifications in > board code. There should be no functional change. > > BALATON Zoltan (8): > hw/ide: Get rid of piix3_init functions > hw/ide: Get rid of piix4_init function > hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h > hw/ide: Move MAX_IDE_BUS define to one header > hw/ide/pci.c: Coding style update to fix checkpatch errors > hw/ide: Do ide_drive_get() within pci_ide_create_devs() > hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h > hw/ide: Remove unneeded inclusion of hw/ide.h > > hw/alpha/dp264.c | 15 +++------------ > hw/hppa/hppa_sys.h | 1 - > hw/hppa/machine.c | 3 --- > hw/i386/pc_piix.c | 20 +++++++++----------- > hw/ide/ahci_internal.h | 1 + > hw/ide/pci.c | 10 ++++++---- > hw/ide/piix.c | 31 +------------------------------ > hw/isa/piix4.c | 14 +++++--------- > hw/mips/mips_fulong2e.c | 6 +----- > hw/mips/mips_malta.c | 6 ++---- > hw/mips/mips_r4k.c | 4 +--- > hw/ppc/mac_newworld.c | 2 -- > hw/ppc/mac_oldworld.c | 2 -- > hw/ppc/prep.c | 3 --- > hw/sparc64/sun4u.c | 7 +------ > include/hw/ide.h | 6 ------ > include/hw/ide/internal.h | 3 +++ > include/hw/ide/pci.h | 3 ++- > include/hw/misc/macio/macio.h | 1 + > include/hw/southbridge/piix.h | 3 +-- > 20 files changed, 37 insertions(+), 104 deletions(-)
This looks like a good clean-up to me, but certainly it would be good to get a second opinion from people more familiar with the IDE code internals. Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> ATB, Mark.
