ping!
Is there any other comments/concerns/objections/suggestions according to
the series except the minor ones from Alberto and Vladimir?
If not, please, let me know, so I can resend the series with the minor
changes for applying to the corresponding branch.
Thanks!
Denis
On 04.03.2020 16:35, Denis Plotnikov wrote:
v5:
* replace -ENOTSUP with abort in qcow2_co_decompress [Vladimir]
* set cluster size for all test cases in the beginning of the 287 test
v4:
* the series is rebased on top of 01 "block/qcow2-threads: fix
qcow2_decompress"
* 01 is just a no-change resend to avoid extra dependencies. Still, it may
be merged in separate
v3:
* remove redundant max compression type value check [Vladimir, Eric]
(the switch below checks everything)
* prevent compression type changing on "qemu-img amend" [Vladimir]
* remove zstd config setting, since it has been added already by
"migration" patches [Vladimir]
* change the compression type error message [Vladimir]
* fix alignment and 80-chars exceeding [Vladimir]
v2:
* rework compression type setting [Vladimir]
* squash iotest changes to the compression type introduction patch
[Vladimir, Eric]
* fix zstd availability checking in zstd iotest [Vladimir]
* remove unnecessry casting [Eric]
* remove rudundant checks [Eric]
* fix compressed cluster layout in qcow2 spec [Vladimir]
* fix wording [Eric, Vladimir]
* fix compression type filtering in iotests [Eric]
v1:
the initial series
Denis Plotnikov (4):
qcow2: introduce compression type feature
qcow2: rework the cluster compression routine
qcow2: add zstd cluster compression
iotests: 287: add qcow2 compression type test
Vladimir Sementsov-Ogievskiy (1):
block/qcow2-threads: fix qcow2_decompress
docs/interop/qcow2.txt | 20 +++
configure | 2 +-
qapi/block-core.json | 23 +++-
block/qcow2.h | 18 ++-
include/block/block_int.h | 1 +
block/qcow2-threads.c | 206 ++++++++++++++++++++++++++++---
block/qcow2.c | 108 ++++++++++++++++
tests/qemu-iotests/031.out | 14 +--
tests/qemu-iotests/036.out | 4 +-
tests/qemu-iotests/049.out | 102 +++++++--------
tests/qemu-iotests/060.out | 1 +
tests/qemu-iotests/061.out | 34 ++---
tests/qemu-iotests/065 | 28 +++--
tests/qemu-iotests/080 | 2 +-
tests/qemu-iotests/144.out | 4 +-
tests/qemu-iotests/182.out | 2 +-
tests/qemu-iotests/242.out | 5 +
tests/qemu-iotests/255.out | 8 +-
tests/qemu-iotests/287 | 128 +++++++++++++++++++
tests/qemu-iotests/287.out | 43 +++++++
tests/qemu-iotests/common.filter | 3 +-
tests/qemu-iotests/group | 1 +
22 files changed, 644 insertions(+), 113 deletions(-)
create mode 100755 tests/qemu-iotests/287
create mode 100644 tests/qemu-iotests/287.out