On 3/7/20 4:13 AM, Mark Cave-Ayland wrote:
> The recent cmd646 discussions reminded me of this patch I've had sitting in an
> old branch for a while.
>
> The DP264 machine is the last remaining user of the deprecated
> pci_cmd646_ide_init() init function. Switch it over to using qdev via
> pci_create()
> and then remove the now-unused pci_cmd646_ide_init() function.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
>
> v3:
> - Rebase onto master
> - Add R-B tag from Phil
> - Use pci_create_simple() instead of pci_create() as suggested by Zoltan
>
> v2:
> - Rebase onto master
> - Remove setting "secondary" property to 0 for dp264 since this is already
> the default
> - Add R-B tags from Richard
>
>
> Mark Cave-Ayland (2):
> dp264: use pci_create_simple() to initialise the cmd646 device
> cmd646: remove unused pci_cmd646_ide_init() function
>
> hw/alpha/dp264.c | 6 +++++-
> hw/ide/cmd646.c | 12 ------------
> include/hw/ide.h | 2 --
> 3 files changed, 5 insertions(+), 15 deletions(-)
>
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js