On Thu, Mar 5, 2020 at 8:52 AM Peter Maydell <peter.mayd...@linaro.org> wrote:
>
> On Tue, 3 Mar 2020 at 00:49, Palmer Dabbelt <palmerdabb...@google.com> wrote:
> >
> > From: Alistair Francis <alistair.fran...@wdc.com>
> >
> > The v0.5 Hypervisor spec add new execption numbers, let's add support
> > for those.
> >
> > Signed-off-by: Alistair Francis <alistair.fran...@wdc.com>
> > Reviewed-by: Palmer Dabbelt <palmerdabb...@google.com>
> > Signed-off-by: Palmer Dabbelt <palmerdabb...@google.com>
> > ---
> > target/riscv/cpu.c | 8 ++++++++
> > target/riscv/cpu_bits.h | 35 +++++++++++++++++++----------------
> > target/riscv/cpu_helper.c | 7 +++++--
> > target/riscv/csr.c | 7 +++++--
> > 4 files changed, 37 insertions(+), 20 deletions(-)
> >
> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > index efbd676edb..2f62f5ea19 100644
> > --- a/target/riscv/cpu.c
> > +++ b/target/riscv/cpu.c
> > @@ -67,6 +67,14 @@ const char * const riscv_excp_names[] = {
> > "load_page_fault",
> > "reserved",
> > "store_page_fault"
> > + "reserved",
>
> Hi; Coverity (CID 1420223) notice that there's no comma
> after "store_page_fault", which means that there's been
> a concatenation of that string and the following "reserved".
> Could one of you send a patch which adds the missing comma?
>
> > + "reserved",
> > + "reserved",
> > + "reserved",
> > + "guest_exec_page_fault",
> > + "guest_load_page_fault",
> > + "reserved",
> > + "guest_store_page_fault"
>
> You might also like to add a trailing comma here to avoid
> the bug happening again in future.
Thanks for the report Peter, I'll send a patch.
Alistair
>
> > };
> >
>
> thanks
> -- PMM
>
