Alex Bennée <alex.ben...@linaro.org> wrote: > Juan Quintela <quint...@redhat.com> writes: > >> Alex Bennée <alex.ben...@linaro.org> wrote: >>> Alex Bennée <alex.ben...@linaro.org> writes: >>>
>> >> Can you told me what architecture/distro/os are you using. > > It broke on the CI setup - it could be another issue with the ageing > Travis images (Ubuntu 16.04). > >>> Dropping this patch as it breaks the build even more! >>> >>> CC migration/block.o >>> >>> /home/travis/build/stsquad/qemu/migration/multifd-zstd.c:24:5: error: >>> unknown type name ‘ZSTD_CStream’ >>> >>> ZSTD_CStream *zcs; >>> >>> ^ >> >> This is really weird. if you arrive here, that means: >> - you have zstd devel installed (whatever is that called for your >> os/distro/whatever). > > Well it detected it: > > zstd support yes > >> >> - pkg-config has found zstd devel packages and configured them (that >> file depends on CONFiG_ZSTD beoing defined) >> >> - gcc has found <zstd.h> (i.e. it don't give one error about that >> include file not found). >> >> And zstd don't have ZSTD_CStream defined? What is going on here? >> Can you post/show what is on your zstd.h file? >> What zstd library version do you have? >> >> I thought that zstd was a new library, and that we didn't need to check >> for versions. It appears that I was wrong. And no, the include file >> don't show what features are new/old. > > Obviously not that new but has changed since it first got introduced. I put my archeology hat, and went digging. Streaming API was introduced on this commit: commit 5a0c8e24395079f8e8cdc90aa1659cd5ab1b7427 Author: Yann Collet <yann.collet...@gmail.com> Date: Fri Aug 12 01:20:36 2016 +0200 new streaming API (compression) And it first appears on v0.8.1 version. Posting a better fix on toplevel. If you want to try, I have changed it to: diff --git a/configure b/configure index 7b373bc0bb..1bf48df1ef 100755 --- a/configure +++ b/configure @@ -2464,7 +2464,8 @@ fi # zstd check if test "$zstd" != "no" ; then - if $pkg_config --exist libzstd ; then + libzstd_minver="0.8.1" + if $pkg_config --atleast-version=$libzstd_minver libzstd ; then zstd_cflags="$($pkg_config --cflags libzstd)" zstd_libs="$($pkg_config --libs libzstd)" LIBS="$zstd_libs $LIBS" If you can check that this works for you, thanks.