Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > On 3/3/20 1:56 PM, Juan Quintela wrote: >> Denis Plotnikov <dplotni...@virtuozzo.com> wrote: >>> Package manager --exist flag is used instead of --exists. >>> Fix it. >>> >>> Signed-off-by: Denis Plotnikov <dplotni...@virtuozzo.com> >> >> Reviewed-by: Juan Quintela <quint...@redhat.com> >> >> queued. > > It doesn't seem that trivial: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html
I think you need to do a make clean. And I found why I didn't catch that problem. Fedora pkg-config is soooo intelligent: $ pkg-config --exist libzstd; echo $? 0 $ pkg-config --exists libzstd; echo $? 0 $ pkg-config --exists libzstd33; echo $? 1 $ pkg-config --exist libzstd33; echo $? 1 $ I tried with libzstd-devel installed and uninstalled, with --enable-zstd and --disable-zstd, and it always did the right thing for me. Later, Juan. > >> >> thanks. >> >>> --- >>> configure | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/configure b/configure >>> index 7b373bc0bb..caa65f5883 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -2464,7 +2464,7 @@ fi >>> # zstd check >>> if test "$zstd" != "no" ; then >>> - if $pkg_config --exist libzstd ; then >>> + if $pkg_config --exists libzstd ; then >>> zstd_cflags="$($pkg_config --cflags libzstd)" >>> zstd_libs="$($pkg_config --libs libzstd)" >>> LIBS="$zstd_libs $LIBS" >> >>
