Am 26.02.2020 um 09:46 hat kuhn.chen...@huawei.com geschrieben: > From: Chen Qun <kuhn.chen...@huawei.com> > > Clang static code analyzer show warning: > block/stream.c:186:9: warning: Value stored to 'ret' is never read > ret = 0; > ^ ~ > Reported-by: Euler Robot <euler.ro...@huawei.com> > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > Reviewed-by: John Snow <js...@redhat.com>
Let's mention that this is unnecessary since commit 1d809098aa9. Since the same commit, the initialisation 'int ret = 0;' is unnecessary because we never read ret before overwriting the initial value. We could clean this up in the same patch. With or without the changes: Reviewed-by: Kevin Wolf <kw...@redhat.com>