Re: [PATCH RESEND v2 14/32] hw/sparc: Use memory_region_init_rom() with read-only regions

[KONRAD Frederic]

Le 2/24/20 à 9:55 PM, Philippe Mathieu-Daudé a écrit :

This commit was produced with the Coccinelle script
scripts/coccinelle/memory-region-housekeeping.cocci.

Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>

Looks good to me.

Reviewed-by: KONRAD Frederic <frederic.kon...@adacore.com>

Thanks,
Fred

---
  hw/sparc/leon3.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index f5a087dd86..23d0bdbd71 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -256,8 +256,7 @@ static void leon3_generic_hw_init(MachineState *machine)

/* Allocate BIOS */

      prom_size = 8 * MiB;
-    memory_region_init_ram(prom, NULL, "Leon3.bios", prom_size, &error_fatal);
-    memory_region_set_readonly(prom, true);
+    memory_region_init_rom(prom, NULL, "Leon3.bios", prom_size, &error_fatal);
      memory_region_add_subregion(address_space_mem, LEON3_PROM_OFFSET, prom);

/* Load boot prom */