On 2/25/20 3:09 AM, kuhn.chen...@huawei.com wrote:
From: Chen Qun <kuhn.chen...@huawei.com>Clang static code analyzer show warning: monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read set = true; ^ ~~~~ Reported-by: Euler Robot <euler.ro...@huawei.com> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> --- Cc: "Dr. David Alan Gilbert" <dgilb...@redhat.com> --- monitor/hmp-cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 53bc3f76c4..84f94647cd 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict)if (group->has_set_eth_dst) {if (!set) { - set = true; monitor_printf(mon, " set"); } monitor_printf(mon, " dst %s", group->set_eth_dst);
Can you move the 'set' declaration to the for() statement and also remove the last "set = false;"?
