On 2/19/20 9:55 AM, Julia Suvorova wrote:
Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt
manage it and restrict unplug for the whole machine. This is going to
prevent user-initiated unplug in guests (Windows mostly).
Hotplug is enabled by default.
Usage:
-device pcie-root-port,enable-hotplug=false,...
If you want to disable hot-unplug on some downstream ports of one
switch, disable hot-unplug on PCIe Root Port connected to the upstream
port as well as on the selected downstream ports.
Discussion related:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg00530.html
Signed-off-by: Julia Suvorova <jus...@redhat.com>
---
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04868.html
v2:
* change name of the option to 'enable-hotplug' [Laine]
Heh... I didn't actually expect you to do that just for me :-)
(especially since I guess nobody else was bothered by "disable"). But
now that you did, I look at it and realize that the "enable-" part is
redundant, ie. just "hotplug=on|off|true|false" is plenty descriptive
(since it's implied that it's being enabled).
But I've already created too much of a tempest over such a tiny detail,
and kind of wish I'd just kept quiet instead...
I'll try to test this with libvirt in the next day or two.
* change order of enabling capability bits [Igor]
* enable HPS bit [Igor]
* add option to xio3130_downstream [Ján]
