On 2/17/20 9:33 AM, Igor Mammedov wrote:
> /* We need to initialize our memory */
> if (machine->ram_size > (FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE))
> {
> - warn_report("RAM size " RAM_ADDR_FMT " above max supported, "
> + error_report("RAM size " RAM_ADDR_FMT " above max supported, "
> "reduced to %x", machine->ram_size,
> FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE);
> - machine->ram_size = FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE;
> + exit(EXIT_FAILURE);
The wording here doesn't make sense anymore.
I think it would be better to mirror that used elsewhere:
+ char *sz = size_to_str(mc->default_ram_size);
+ error_report("Invalid RAM size, should be %s", sz);
+ g_free(sz);
With that,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
