Re: [Qemu-devel] [PATCH 10/12] VMDK: change get_cluster_offset return type to success flag

[Stefan Hajnoczi]

On Sat, Jun 4, 2011 at 1:43 AM, Fam Zheng <famc...@gmail.com> wrote:
> +    if (extent->flat) {
> +               if (m_data) {
> +                       m_data->valid = 0;
> +               }

Why copy-paste this...

> +        *cluster_offset = 0;
> +        return 0;
> +    }
>     if (m_data)
>         m_data->valid = 0;

...instead of moving this above the if statement?

Stefan