On Wed, Jan 29, 2020 at 12:56:48PM +0100, Juan Quintela wrote:
> This will store the compression method to use. We start with none.
>
> Signed-off-by: Juan Quintela <quint...@redhat.com>
> Reviewed-by: Markus Armbruster <arm...@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> ---
> hw/core/qdev-properties.c | 13 +++++++++++++
> include/hw/qdev-properties.h | 3 +++
> migration/migration.c | 13 +++++++++++++
> monitor/hmp-cmds.c | 13 +++++++++++++
> qapi/migration.json | 30 +++++++++++++++++++++++++++---
> tests/qtest/migration-test.c | 14 ++++++++++----
> 6 files changed, 79 insertions(+), 7 deletions(-)
>
> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> index 7f93bfeb88..4442844d37 100644
> --- a/hw/core/qdev-properties.c
> +++ b/hw/core/qdev-properties.c
> @@ -8,6 +8,7 @@
> @@ -488,6 +488,19 @@
> ##
> { 'command': 'query-migrate-capabilities', 'returns':
> ['MigrationCapabilityStatus']}
>
> +##
> +# @MultiFDMethod:
> +#
> +# An enumeration of multifd compression.
> +#
> +# @none: no compression.
> +#
> +# Since: 5.0
> +#
> +##
> +{ 'enum': 'MultiFDMethod',
> + 'data': [ 'none' ] }
I feel like "MultiFDMethod" is better called "MultiFDCompression"
> +
> ##
> # @MigrationParameter:
> #
> @@ -586,6 +599,9 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # Defaults to 99. (Since 3.1)
> #
> +# @multifd-method: Which compression method to use.
> +# Defaults to none. (Since 5.0)
> +#
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
> @@ -598,7 +614,7 @@
> 'downtime-limit', 'x-checkpoint-delay', 'block-incremental',
> 'multifd-channels',
> 'xbzrle-cache-size', 'max-postcopy-bandwidth',
> - 'max-cpu-throttle' ] }
> + 'max-cpu-throttle', 'multifd-method' ] }
>
> ##
> # @MigrateSetParameters:
> @@ -688,6 +704,9 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # The default value is 99. (Since 3.1)
> #
> +# @multifd-method: Which compression method to use.
> +# Defaults to none. (Since 5.0)
> +#
> # Since: 2.4
> ##
> # TODO either fuse back into MigrationParameters, or make
> @@ -713,7 +732,8 @@
> '*multifd-channels': 'int',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle': 'int' } }
> + '*max-cpu-throttle': 'int',
> + '*multifd-method': 'MultiFDMethod' } }
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
