On 2/4/20 11:08 AM, Max Reitz wrote:
These calls have no real use for the child role yet, but it will not
harm to give one.

Notably, the bdrv_root_attach_child() call in blockjob.c is left
unmodified because there is not much the generic BlockJob object wants
from its children.

Signed-off-by: Max Reitz <mre...@redhat.com>
---
  block/block-backend.c | 11 +++++++----
  block/vvfat.c         |  2 +-
  2 files changed, 8 insertions(+), 5 deletions(-)


Reviewed-by: Eric Blake <ebl...@redhat.com>

Is it worth an assert(role) somewhere now that you've converted all callers to pass at least one role?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Reply via email to