Le 06/02/2020 à 09:21, Thomas Huth a écrit :
> On 06/02/2020 05.07, kuhn.chen...@huawei.com wrote:
>> From: Chen Qun <kuhn.chen...@huawei.com>
>>
>> Fix warning:
>> hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’:
>> glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be
>> used uninitialized in this function [-Wmaybe-uninitialized]
>> g_free (*pp);
>> ^~~~~~~~~~~~
>> hw/i2c/aspeed_i2c.c:403:22: note: ‘cmd_flags’ was declared here
>> g_autofree char *cmd_flags;
>> ^~~~~~~~~
>>
>> Reported-by: Euler Robot <euler.ro...@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
>> ---
>> hw/i2c/aspeed_i2c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
>> index 9cda968501..fb973a983d 100644
>> --- a/hw/i2c/aspeed_i2c.c
>> +++ b/hw/i2c/aspeed_i2c.c
>> @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus)
>>
>> static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus)
>> {
>> - g_autofree char *cmd_flags;
>> + g_autofree char *cmd_flags = NULL;
>> uint32_t count;
>>
>> if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) {
>>
>
> Thanks. Looks like the same patch that has been reported already here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04492.html
>
> Could someone please pick this up (e.g. qemu-trivial?)?
I will add the patch from Miroslav in my coming pull request.
Thanks,
Laurent
