On 05/02/2020 21:46, Thomas Huth wrote:
> On 05/02/2020 21.41, Laurent Vivier wrote:
>> qtest "rtas" command is only available with pseries not all ppc64 targets,
>> so if I try to compile only powernv machine, the build fails with:
>>
>>   /usr/bin/ld: qtest.o: in function `qtest_process_command':
>>   .../qtest.c:645: undefined reference to `qtest_rtas_call'
>>
>> We fix this by enabling rtas command only with pseries machine.
>>
>> Fixes: eeddd59f5962 ("tests: add RTAS command in the protocol")
> 
> Well, at that point in time CONFIG_PSERIES was not available yet ... so
> not sure if the "Fixes:" really makes sense here...

You are right, but I think it's interesting to show the dependency we
have between patches.

> But apart from that:
> Reviewed-by: Thomas Huth <th...@redhat.com>
> 
Thank you!

Laurent


Reply via email to