Re: [PATCH] pl031: add finalize function to avoid memleaks

[Pan Nengyuan]

On 2/3/2020 3:59 PM, Richard Henderson wrote:
> On 2/3/20 7:47 AM, pannengy...@huawei.com wrote:
>> +static void pl031_finalize(Object *obj)
>> +{
>> +    PL031State *s = PL031(obj);
>> +    if (s->timer) {
> 
> As far as I can see, s->timer can never be null.

Yes, it's no instances, just seems safer.

Thanks.
> 
> Otherwise,
> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
> 
> 
> r~
>