Patchew URL: https://patchew.org/QEMU/1579904044-20790-1-git-send-email-wall...@linux.ibm.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1579904044-20790-1-git-send-email-wall...@linux.ibm.com Subject: [PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1579904044-20790-1-git-send-email-wall...@linux.ibm.com -> patchew/1579904044-20790-1-git-send-email-wall...@linux.ibm.com Switched to a new branch 'test' bf39c82 s390: diagnose 318 info reset and migration support 7a5ff34 s390/kvm: header sync for diag318 === OUTPUT BEGIN === 1/2 Checking commit 7a5ff34d93c1 (s390/kvm: header sync for diag318) 2/2 Checking commit bf39c8211f83 (s390: diagnose 318 info reset and migration support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 ERROR: braces {} are necessary for all arms of this statement #64: FILE: hw/s390x/diag318.c:22: + if (kvm_enabled()) [...] ERROR: braces {} are necessary for all arms of this statement #74: FILE: hw/s390x/diag318.c:32: + if (kvm_enabled()) [...] ERROR: braces {} are necessary for all arms of this statement #100: FILE: hw/s390x/diag318.c:58: + if (kvm_enabled()) [...] ERROR: adding a line without newline at end of file #173: FILE: hw/s390x/diag318.h:40: +#endif /* HW_DIAG318_H */ WARNING: line over 80 characters #314: FILE: target/s390x/cpu_features_def.inc.h:124: +DEF_FEAT(DIAG318, "diag318", SCLP_BYTE_134, 0, "Control program name and version codes") total: 4 errors, 2 warnings, 310 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1579904044-20790-1-git-send-email-wall...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
