On Thu, Jan 23, 2020 at 12:37:46PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and using MachineState::ram instead of manually initializing > RAM memory region. > > PS: > while at it add check for user supplied RAM size and error > out if it mismatches board expected value. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > v2: > * fix format string causing build failure on 32-bit host > (Philippe Mathieu-Daudé <phi...@redhat.com>) > > CC: drjo...@redhat.com > CC: peter.mayd...@linaro.org > CC: qemu-...@nongnu.org > --- > hw/arm/mps2.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-)
I don't know anything about mps2, but I promised Igor to put another pair of eyes on his changes. Looks fine to me. Reviewed-by: Andrew Jones <drjo...@redhat.com>
